942 Commits

Author SHA1 Message Date
Nikos Tsipinakis
7da60b998e Merge pull request #409 from bebehei/issue-template
Add issue template
2017-10-20 20:34:08 +03:00
Nikos Tsipinakis
d06c471053 Merge pull request #416 from bebehei/unref-notify
Free notification before closing
2017-10-19 05:20:39 +03:00
Benedikt Heine
ca996c9596 Free notification before closing
The notification object should actually get freed by notify_uninit. But
before freeing the notification, notify_uninit also sends the
CloseNotification signal directly, if the timeout is 0.

But the timeout of 0 should actually indicate a notification, which
never expires.

Fixes #415
2017-10-18 23:45:15 +02:00
Nikos Tsipinakis
bc9ddff637 Merge pull request #410 from EdwardBetts/patch-1
correct spelling mistake
2017-10-11 17:29:15 +03:00
Edward Betts
5f87039946 correct spelling mistake 2017-10-10 23:41:08 +01:00
Benedikt Heine
0b9dda26f9 Add issue template 2017-10-10 15:06:22 +02:00
Nikos Tsipinakis
4d59e3a2e2 Merge pull request #407 from bebehei/gnu-source
Remove _GNU_SOURCE macro
2017-10-08 16:28:36 +03:00
Benedikt Heine
be3636c679 Remove _GNU_SOURCE macro
After some research, the _GNU_SOURCE does not affect any function call
anymore. To avoid future failures on other systems not using glibc,
_GNU_SOURCE gets removed.
2017-10-08 02:32:37 +02:00
Nikos Tsipinakis
e8e4af9ea3 Temporarily remove invalid value test in string_to_time
As mentioned in #368 testing for invalid values with the current
implementation would result in misleading error messages being printed
to stdout. These tests should be disabled until a solution is found.
2017-10-07 19:05:49 +03:00
Nikos Tsipinakis
fe2a3b5049 Merge pull request #379 from bebehei/timeout-in-msecs
Timeout in msecs
2017-10-07 18:59:00 +03:00
Benedikt Heine
81ff86299f Change boundary conditions in run() 2017-10-07 17:46:24 +02:00
Benedikt Heine
1f0e8d2181 overhaul get_sleep_time 2017-10-07 17:46:24 +02:00
Benedikt Heine
5d46cd700c Add option_get_time functions 2017-10-07 17:46:24 +02:00
Benedikt Heine
956b5c6401 Use gint64 as microseconds for internal timeunit
time(NULL) is vulnerable against timeshifts by NTP, timezones,...

g_get_monotonic_time() is not, but counts its in microseconds with the
gint64 datatype. To prevent any conversion bugs, all internal
timeformats are now using a gint64 and only get converted during import
or export (DBus notification arrives, configuration reading, age
threshold display).
2017-10-07 17:46:21 +02:00
Benedikt Heine
7a02d8e48a Microoptimisation in get_sleep_time
Setting the value to INT_MAX instead of 0 allows to remove the boolean
check if value even has been set.
2017-10-07 17:45:57 +02:00
Nikos Tsipinakis
4c09b4370a Merge pull request #406 from bebehei/default-icons
Change default icons to match freedesktop spec
2017-10-07 15:38:18 +03:00
Benedikt Heine
11aef25bd5 Change default icons to match freedesktop spec 2017-10-07 12:08:24 +02:00
Nikos Tsipinakis
a56bdd18c1 Merge pull request #401 from bebehei/flickerless-replace
Update notification attributes upon direct replace
2017-10-06 22:32:49 +03:00
Nikos Tsipinakis
a18b4d8895 Merge pull request #402 from bebehei/unused-fields
Remove unused struct fields
2017-10-06 22:29:01 +03:00
Nikos Tsipinakis
478377815f Merge pull request #403 from bebehei/redo-354
Work around non-gnu basename implementations
2017-10-06 22:24:39 +03:00
Nikos Tsipinakis
c55308b8a7 Initialize icons before parsing the format
Since the format supports flags for including the icon name in the
notification the icon should be initialized first (and set to the
default if not set) in order for the flag to function properly.
2017-10-06 22:14:37 +03:00
Benedikt Heine
9aba546258 Work around non-gnu basename implementations
Redo #354, as it got pushed out in #365
2017-10-06 20:29:21 +02:00
Benedikt Heine
d6c1fbb556 Remove unused struct fields 2017-10-06 18:33:56 +02:00
Nikos Tsipinakis
0a3298dde4 Merge pull request #387 from bebehei/tests-for-string-append
Tests for string append
2017-10-06 18:17:50 +03:00
Nikos Tsipinakis
2799df7b5c Merge pull request #400 from bebehei/systemdremove
Remove systemdfile on uninstall
2017-10-06 18:10:47 +03:00
Benedikt Heine
8b102a4483 Remove systemd service on uninstall 2017-10-06 14:49:15 +02:00
Benedikt Heine
e8f152b5d0 Update notification attributes upon direct replace 2017-10-06 13:31:26 +02:00
Benedikt Heine
6e654eb751 Improve usage of string_append 2017-10-06 13:13:47 +02:00
Benedikt Heine
a6301ff464 Do not concatenate empty strings with separator 2017-10-06 13:13:47 +02:00
Nikos Tsipinakis
82d544e95e Merge pull request #391 from bebehei/flickerless-replace
Replace notifications flickerless
2017-10-05 16:34:26 +03:00
Nikos Tsipinakis
70a709a534 Merge pull request #396 from bebehei/memory-leak_2
Fix small memory leak
2017-10-05 15:31:27 +03:00
Benedikt Heine
5680291c20 Fix small memory leak 2017-10-05 12:39:58 +02:00
Benedikt Heine
1533fcd782 Replace notifications flickerless
Previously, notifications had been replaced by removing the notification
out of the displayed/queue lists, redrawing the window and then adding
the new notification into the queue. This produced a flickering in
dunst.

By avoiding the overhead of closing and opening the window (simply
replacing the datapointer of the list), the flickering disappears.
2017-09-27 00:24:21 +02:00
Nikos Tsipinakis
a64cb82946 Merge pull request #388 from fhost/fhost/ellipsize
Use config.h for default ellipsize value
2017-09-26 09:32:11 +03:00
Nikos Tsipinakis
a685d9885d Merge pull request #386 from bebehei/option-parser-const-args
Option parser const args
2017-09-26 09:21:59 +03:00
Nikos Tsipinakis
ec48113e54 Merge pull request #385 from ericfreese/master
Add possible values for `ellipsize` to dunstrc
2017-09-26 07:42:01 +03:00
Benedikt Heine
a1781a451b Check for b value if null in string_append
This avoids "a", NULL, "sep" to come to "asep" instead of "a".
2017-09-25 03:55:19 +02:00
Benedikt Heine
8b11113be1 Implement test_string_append 2017-09-25 03:54:37 +02:00
Benedikt Heine
41defb7c85 Break overlong argument lists 2017-09-25 02:26:11 +02:00
Benedikt Heine
554c873808 Mark constant strings as const
It's hard to trace back, which methods in option parser require freeing
the result and which prohibit it. Marking all non-freeable values as
const lets this problem solve the compiler.
2017-09-25 02:26:11 +02:00
Eric Freese
26c0500e5c Add possible values for ellipsize to dunstrc
Follow-up to f4b5952
2017-09-24 10:19:20 -06:00
fhost
f9f6830c71 Use config.h for default ellipsize value
Get the default value for ellipsize from config.h, instead of
setting it in two different places (in case it is not set, and in
case its value is invalid).
2017-09-24 16:53:58 +02:00
Nikos Tsipinakis
4316c85e18 Merge pull request #374 from fhost/fhost/ellipsize
Add option to control how to ellipsize truncated lines
2017-09-20 16:40:22 +03:00
Nikos Tsipinakis
ad31bb975c Merge pull request #381 from bebehei/typo-1
Rename double to int
2017-09-20 10:32:29 +03:00
fhost
f4b595240a Add option to control how to ellipsize truncated lines 2017-09-19 20:03:16 +02:00
Benedikt Heine
530eaaf5ed Rename double to int 2017-09-19 13:26:30 +02:00
Nikos Tsipinakis
8a0c0d3756 Merge pull request #378 from bebehei/style
Correct indentation
2017-09-19 09:12:31 +03:00
Benedikt Heine
1c7f674ee0 Correct indentation 2017-09-19 00:10:36 +02:00
Nikos Tsipinakis
2acc4be55b Merge pull request #372 from bmwiedemann/sort
Sort linker input file list
2017-09-13 07:56:46 +03:00
Bernhard M. Wiedemann
5df95513ec Sort linker input file list
so that dunst binaries build in a reproducible way
in spite of indeterministic filesystem readdir order

See https://reproducible-builds.org/ for why this is good.
2017-09-12 21:26:30 +02:00