1220 Commits

Author SHA1 Message Date
Sascha kruse
562cb93767 remove unneeded declaration extract_urls 2018-09-14 13:29:13 +02:00
Benedikt Heine
76fecedfd8
Merge pull request #544 from knopwob/master
draw the window before showing it
2018-09-13 16:55:33 +02:00
Sascha kruse
e09e29968a draw the window before showing it
Before this commit when using Dunst with multiple displays and
follow mode mouse/keyboard on a new notification (when no other
notifications are shown) a black window flickers up at the screen where
the last notification was shown.

By calling draw() before x_window_show the new window position will be
calculated and the window will be moved there before the window is shown
and thus remove the flickering.
2018-09-13 16:03:26 +02:00
Nikos Tsipinakis
e5dd80b9db
Merge pull request #542 from bebehei/hotfix1
Wakeup also for infinite notifs when set show_age_threshold
2018-09-08 19:51:42 +03:00
Benedikt Heine
faec6bdbca Wakeup also for infinite notifs when set show_age_threshold
For notifications without any timeout, ttl can't be positive.
So when, show_age_threshold is active, dunst won't wake up, if there
are only notifications displayed without any timeout.
2018-09-06 11:13:46 +02:00
Nikos Tsipinakis
896c008def
Merge pull request #537 from bebehei/icon-nullcheck
Avoid NULL values in fnmatch's parameters
2018-08-17 14:03:23 +03:00
Benedikt Heine
076b6936ec Avoid NULL values in fnmatch's parameters
While the rule's field will get checked for a NULL value, the
notification's field won't get, as it's assumed to be non-NULL.

This is problematic, as there can be some corner cases, where the
notification's field is actually NULL.

Fixes #536
2018-08-16 10:25:19 +02:00
Nikos Tsipinakis
a749847040
Merge pull request #535 from Saeissl/master
Add a toggle command
2018-08-11 18:43:09 +03:00
David Sauerwein
bb60ea7a48 Add a toggle command 2018-08-11 11:08:03 +02:00
Nikos Tsipinakis
0e1b5a176a
Merge pull request #525 from lulivi/master
Added dunst xresources theme wrapper
2018-07-15 12:03:15 +03:00
Nikos Tsipinakis
c0eef2da2f
Merge pull request #530 from zijung/feature-mouse_event
Add options to specify mouse event
2018-07-15 11:59:10 +03:00
lulivi
cbfe8c0d61 Add xresources config wrapper
Created a wrapper script to customize theme variables (colors,
fonts, etc) according with your X resources file (~/.Xresources).

As dunst is not a X exclusive notification daemon, this script
could be a workarround to solve this.

Related with: #357
2018-07-15 00:14:04 +00:00
Zijung Chueh
88175b259a Put the default value in the defaults 2018-07-13 21:31:51 +08:00
Zijung Chueh
7a22fa0e5f Fix code style
* Move mouse_left/middle/right_click to global section
  * Match the enum value style
  * Ignore unknow mouse event
  * Split copy-paste code into a function
  * Fix typo
2018-07-13 14:45:38 +08:00
Zijung Chueh
fbcc26b5e1 Add options to specify mouse event 2018-07-13 01:40:20 +08:00
Nikos Tsipinakis
6d0e20e40b
Merge pull request #528 from bebehei/various
Various Improvements
2018-07-11 13:09:08 +03:00
Benedikt Heine
368182f4d7 Log XEvents by their written names
All XEvents only got logged with their IDs. It makes more sense to write
out the XEvent's name. Also, writing that we received an XEvent and then
logging again, that we ignored it, makes no sense.
2018-07-10 13:35:51 +02:00
Benedikt Heine
3c69e1f263 Remove doubly variables while converting dbus message 2018-07-10 13:35:51 +02:00
Benedikt Heine
646d037b15 Make NULL a valid input for notification_free 2018-07-10 13:23:12 +02:00
Benedikt Heine
54ce81ccca Convert notification.[ch] into docstrings 2018-07-10 13:23:12 +02:00
Benedikt Heine
f4fb95c827 Do not make explicit NULL checks on elements
Most of the NULL checks are actually doubly false logic. Turning the
logic around and removing the NULL check makes the program easier to
read.
2018-07-10 13:23:12 +02:00
Benedikt Heine
7187290536 Turn read only fields into const 2018-07-10 13:23:05 +02:00
Nikos Tsipinakis
f1dd772937
Merge pull request #527 from bebehei/better-msgs-icon
Better warnings for failed icons
2018-07-08 10:18:49 +03:00
Benedikt Heine
b5fbfd0e65 Print progress in notification_print 2018-07-07 11:55:06 +02:00
Benedikt Heine
a229363dbd Simplify colored_layout codepaths 2018-07-07 11:54:41 +02:00
Benedikt Heine
f410f57211 Use g_clear_pointer on fields, which may get reused 2018-07-07 11:53:32 +02:00
Benedikt Heine
e091dd4d15 Notification comparison done right 2018-07-07 11:51:14 +02:00
Benedikt Heine
e4b0aae05a Replace free(val); val=NULL; with g_clear_pointer 2018-07-07 11:51:03 +02:00
Benedikt Heine
8399ef2d7c Better warnings for failed icons
As the get_pixbuf_from_file should retrieve a file's content, it
shouldn't fail silently, if the file isn't there.

For codepaths, which don't use the `icon_path` to search for a given
icon, it gives a clearer error message.
2018-07-06 14:20:01 +02:00
Nikos Tsipinakis
ae370e7289 dunstify: Fix escape chars not being parsed in the body
notify-send uses g_strcompress on the body of the notification to
replace escape chars (e.g. newline). Since dunstify is supposed to be a
drop-in replacement we should match that here as well.
2018-07-05 12:55:24 +03:00
Nikos Tsipinakis
74bbc96db2
Merge pull request #521 from bebehei/paths-for-icons
Implement paths for icons
2018-06-24 11:19:06 +03:00
Benedikt Heine
a2b383ec0b Add Tests for tilde expansion in icons 2018-06-23 23:49:25 +02:00
Nikos Tsipinakis
8b2d5c49ba
Merge pull request #523 from bebehei/xfreegc
Fix X11 memoryleak for round corners
2018-06-23 16:51:11 +03:00
Benedikt Heine
0e5034b02a Fix X11 memoryleak for round corners
When using round corners, the shape_gc in x_win_round_corners never got
freed. This created a memory leak in x11 itself and let the X process
create more load while becoming sluggish in some situations.

From the docs, XFreeGC actually could return an int and could throw a
BadGC error. Neither of them are important to catch in our situation:

- Having a look into the Xlib sourcecode, XFreeGC returns always 1.
- As we don't overwrite the shape_gc or do any other destoying calls,
  the BadGC can't happen in this code.
2018-06-22 11:55:34 +02:00
Benedikt Heine
646a35d2da Do not search absolute paths in the icon_path
The icon_path has no point for searching an absolute filename. It was
actually meant to avoid the complex lookup algorithm of the icon theme
spec. And the iconname in this case should be actually just the icon's
basename when searching the path.

Concatenating icons like `~/testimg.png` with all icon paths has no
point and also an additional suffix has no point.
2018-06-19 10:37:08 +02:00
Benedikt Heine
42cc561569 Implement tilde replacing in icon names 2018-06-19 10:24:24 +02:00
Nikos Tsipinakis
7bcb287ca2
Merge pull request #517 from bebehei/typos
Fix typos
2018-06-12 12:30:58 +03:00
Benedikt Heine
0a057450fe Fix typos 2018-06-11 14:10:07 +02:00
Nikos Tsipinakis
a0f21f5c26 Stop trying to setup round corners with 0 radius
If corner_radius is 0 we do not need to do the entire process of setting
up the shaped window.
2018-05-29 11:36:51 +03:00
Nikos Tsipinakis
15c252afb0
Merge pull request #420 from dj95/feature/round_corners
Added: support for round corners
2018-05-28 14:03:32 +03:00
Benedikt Heine
aab9fef78c Simplify corner arcs in X11 code 2018-05-28 13:41:31 +03:00
Benedikt Heine
d5fd674d2f Simplify corner arcs in cairo 2018-05-28 13:36:45 +03:00
dj95
a3034d5f62 Implement support for round corners 2018-05-28 13:36:45 +03:00
Nikos Tsipinakis
71791c17e2
Merge pull request #515 from bebehei/maint-addr
Update maintainer addresses
2018-05-15 18:10:10 +03:00
Benedikt Heine
aed3fd30c0 Link the License in README 2018-05-15 17:01:08 +02:00
Benedikt Heine
d4ffa0e0ad Update maintainer addresses 2018-05-15 16:57:37 +02:00
Benedikt Heine
de89328359
Merge pull request #496 from dunst-project/refactor-drawing
Drawing refactor
2018-05-14 11:22:52 +02:00
Nikos Tsipinakis
4891710af3 Refactor window_x11 struct to be opaque
This removes window accesses from outside the x.c file which will allow
us to abstract the window struct to implement multiple outputs in the
future.
2018-05-14 10:39:46 +03:00
Nikos Tsipinakis
54face5956 Fix unchecked corner case in icon_position check
In the case that cl->icon is not NULL we assume that icon_position is
either left or right but this might not always be the case in the
future.
2018-05-14 09:31:53 +03:00
Benedikt Heine
119340c07d Remove unused and superfluous macro definitions 2018-05-14 09:31:53 +03:00