760 Commits

Author SHA1 Message Date
Nikos Tsipinakis
c6d783f5e2 Replace null checks with assert calls
In my opinion, it's better to crash early when something is wrong than
to pretend it never happened. This change will allow us to catch more
in the long run.
2017-01-01 17:15:29 +02:00
Nikos Tsipinakis
86fbde2de1 Implement distclean target
distclean target should restore the directory tree to the state it
originally before make was invoked. In our case it means calling the
clean target to remove the compiled blobs and removing the
auto-generated config.h.
2017-01-01 17:08:10 +02:00
Nikos Tsipinakis
0cb1524cc6 Don't check return status of notification_create
notification_create is guaranteed to return a pointer to a notification,
if the memory allocation fails it throws an error and exits the program.
2017-01-01 17:05:25 +02:00
Nikos Tsipinakis
0a0c02021d Update functions in dbus.c to use camel_case for consistency 2016-12-22 20:00:45 +02:00
Nikos Tsipinakis
de9c52f98f Implement notification_create function
notification_create currently simply allocates memory and zeroes it to
properly initialise a notification. Since we currently have at least 2
places in the code that create notifications(startup notification in
dunst.c and notifications from dbus in dbus.c) the creation should be
handled from a central location in case we ever need to change the
creation procedure later on.
2016-12-22 19:49:29 +02:00
Nikos Tsipinakis
6c9de72c7d Don't consider notifications duplicate if icon or urgency differ
Expand the duplication checking functionality to also check for urgency
and icons. If icons are turned off in the settings the icon check is
skipped.

Icons matching is done based on the given path, if the path differs or
an icon name is used for one notification but an absolute path for
another, the icons are considered different even if they refer to the
same file.
2016-12-22 19:45:38 +02:00
Eizen
f32659adb7 Add systemd service unit to contrib
Apply sed to reflect prefix but don't install it and clean service file in makefile. Add service file to gitignore
2016-12-21 01:57:16 -03:00
Nikos Tsipinakis
810637b2b6 Fix typos 2016-12-18 17:14:02 +02:00
Eizen
16256d316e Merge release notes into a single file 2016-12-17 17:25:46 -03:00
Luke Shumaker
2c93c7a277 Use the appropriate string search functions instead of strstr everywhere.
This mostly means using strchr, but I also found:
  option_parser.c:load_ini_file:
    - replace multiple calls to strstr with strpbrk
  notification.c:notification_init:
    - replace string_replace in a while loop with a single call to
      string_replace_char

redo string replace all
2016-12-17 17:00:43 -03:00
Nikos Tsipinakis
187d3f9ab9 Invalid boolean values should fall back to the default
Previously, an invalid value was always false
2016-12-15 19:13:08 +02:00
Nikos Tsipinakis
a2e0a6efe7 Remove whitespace from empty line 2016-12-15 18:38:34 +02:00
Eizen
bfd24224aa Merge pull request #270 2016-12-13 20:36:55 -03:00
Nikos Tsipinakis
f54d698cba Bring default config up to date
Some of the settings weren't included in the default config before.
2016-12-11 14:14:18 +02:00
Nikos Tsipinakis
e3cbe3883a The manpage should be built to the docs directory
In the spirit of keeping everything organised, the compiled docs should
be in the same directory as the files used to compile them.
2016-12-11 13:48:12 +02:00
Nikos Tsipinakis
ad6557239a Fix incorrect indentation 2016-12-11 13:41:43 +02:00
Nikos Tsipinakis
41d3b61f3c Fix compiler warnings when compiling dunstify 2016-12-11 13:26:20 +02:00
Nikos Tsipinakis
2fe2497506 Add the test binary to gitignore 2016-12-11 13:23:25 +02:00
Eizen
987ec09dec Update manpage 2016-12-03 17:44:16 -03:00
Eizen
7f8648742f Fix memory leak
Incorrect call to disposal function, cairo_destroy should be used per cairo documentation.
2016-12-03 17:42:17 -03:00
Nikos Tsipinakis
b9619a1460 Add option parser test suite 2016-12-03 19:33:40 +02:00
Nikos Tsipinakis
9333d68656 Use the suite_ prefix for test suites 2016-12-03 19:19:10 +02:00
Nikos Tsipinakis
bae745b1fd Don't use ini_get_int to get doubles
option_get_double used ini_get_int to retrieve values from the config
file, changed it to use ini_get_double so that decimal accuracy isn't
lost.
2016-12-03 19:16:32 +02:00
Eizen
7f12704b07 Merge branch 'master' of tsipinakis/dunst 2016-11-22 15:35:27 -03:00
Eizen
2d562968c0 Fix raw data when icon position is off and uninitialized pointer 2016-11-22 15:22:28 -03:00
Nikos Tsipinakis
256440b25a Implement tests for most of the util functions
Also improved the implementation of the test_string_replace_char test.
2016-11-22 18:47:38 +02:00
Nikos Tsipinakis
756dee58c7 Remove unused function 2016-11-22 17:55:28 +02:00
Sascha Kruse
360985b11a update readme with maintainership info 2016-11-22 13:24:57 +01:00
Eizen
2784950f45 Fix uninitialized value warning and code indentation 2016-11-22 01:47:42 -03:00
Eizen
d605c91790 Fix merge commit 2016-11-20 00:03:25 -03:00
Eizen
b6dafbd444 Merge pull request #174 2016-11-19 23:58:17 -03:00
Eizen
b8364f4104 Fix missing link README 2016-11-19 20:16:35 -03:00
Eizen
dfdc082687 Change README
Move README to docs/dunst.pod to be used as man page. Write a README with building instructions and dependencies. Remove INSTALL as it's no longer necessary.
2016-11-19 20:11:21 -03:00
Nikos Tsipinakis
d441e950d8 Implement test target and add the first test
make test will now compile the tests to test/test.
The first test, testing string_replace_char from utils.c, was added.
2016-11-19 12:26:00 +02:00
Nikos Tsipinakis
7ba0fe03ae Add 'greatest' testing framework
Never used this framework before but it seems promising.
2016-11-19 12:17:23 +02:00
Nikos Tsipinakis
e0a8b233c2 Move the main function to main.c
Move the main function to main.c in the git root to allow for
alternative main functions to be linked in its place. Specifically this
will be used to link the test runner main to run tests.
2016-11-19 12:15:39 +02:00
Nikos Tsipinakis
32fb32f96f Split clean and install targets to *-doc *-dunst
This allows better control over when to clean and install, and is more
easily expandable in the long run.
2016-11-19 12:08:27 +02:00
Nikos Tsipinakis
2df2e7d06c Move dunst source files to src/ 2016-11-19 11:54:03 +02:00
Nikos Tsipinakis
4b36abff9a Fix uninitialised pointer warning 2016-11-18 21:30:48 +02:00
Nikos Tsipinakis
8cadd8f905 Don't indent top-level comments 2016-11-17 22:11:08 +02:00
Nikos Tsipinakis
7e58e5c64c Add expandtab to vim modelines & expand abbreviations
Add expandtab to vim modelines so that spaces are expanded to tabs, make
life easier for people that have vim configured to use tabs by default.

Expand modeline abbreviations to improve readability.
2016-11-17 20:27:46 +02:00
Nikos Tsipinakis
9dd4768a1f Switch to _DEFAULT_SOURCE, _BSD_SOURCE is deprecated 2016-11-17 19:50:00 +02:00
Jack Henschel
9db667be45 Add note about ctrl+grave to default config
Fixes #268
2016-11-10 01:20:20 -03:00
vimbaer
69537c2c1d Don't trim leading whitespace, fixes #208.
Use g_strchomp (https://developer.gnome.org/glib/stable/glib-String-Utility-Functions.html#g-strchomp) instead of g_strstrip which both removes leading and trailing whitespace.
2016-11-10 00:48:42 -03:00
Eizen
812b3f972f Merge pull request #210 2016-11-10 00:35:55 -03:00
Yuri D'Elia
cf910b0683 Avoid allocations in string_replace_at when possible. 2016-11-10 00:32:18 -03:00
Yuri D'Elia
98566667c7 Consistent indentation. 2016-11-10 00:32:18 -03:00
Yuri D'Elia
4b53e44d92 Avoid allocations by performing stripping in-place
Introduce a helper function (string_strip_delimited).
2016-11-10 00:32:18 -03:00
Yuri D'Elia
bed4877d7b Fix/simplify notification_strip_markup
- Strip markup before interpreting entitites.
- Handle *any* tag uniformly (<span> is also handled by pango)
2016-11-10 00:32:18 -03:00
Jakob Nixdorf
8ee86dc477 add initial support for per-urgency frame-colors 2016-11-06 16:52:13 -03:00