nagbalae/dunst
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Replace null checks with assert calls

Browse Source 
In my opinion, it's better to crash early when something is wrong than
to pretend it never happened. This change will allow us to catch more
in the long run.
This commit is contained in:
Nikos Tsipinakis 2017-01-01 17:13:35 +02:00
parent 86fbde2de1
commit c6d783f5e2
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/notification.c
View File

@ -9,6 +9,7 @@
#include <stdbool.h>
#include <unistd.h>
#include <sys/wait.h>
#include <assert.h>
#include "dbus.h"
#include "x.h"
@ -157,8 +158,7 @@ int notification_is_duplicate(const notification *a, const notification *b)
*/
void notification_free(notification * n)
{
if (n == NULL)
return;
assert(n != NULL);
free(n->appname);
free(n->summary);
free(n->body);
@ -332,8 +332,7 @@ notification *notification_create(void)
*/
int notification_init(notification * n, int id)
{
if (n == NULL)
return -1;
assert(n != NULL);
if (strcmp("DUNST_COMMAND_PAUSE", n->summary) == 0) {
pause_display = true;
@ -569,8 +568,7 @@ int notification_close_by_id(int id, int reason)
*/
int notification_close(notification * n, int reason)
{
if (n == NULL)
return -1;
assert(n != NULL);
return notification_close_by_id(n->id, reason);
}