Don't overwrite settings in children

string_append frees the first argument. While it's a setting,
settings.browser will contain a false dangling pointer.
This commit is contained in:
Benedikt Heine 2018-01-13 23:52:40 +01:00
parent b209d06963
commit 87c0fd4d90

View File

@ -115,8 +115,7 @@ void open_browser(const char *in)
if (browser_pid2) {
exit(0);
} else {
char *browser_cmd =
string_append(settings.browser, url, " ");
char *browser_cmd = g_strconcat(settings.browser, " ", url, NULL);
char **cmd = g_strsplit(browser_cmd, " ", 0);
execvp(cmd[0], cmd);
// execvp won't return if it's successful