From 87c0fd4d90a0547a7cc744aaaa39d25eeb2c9334 Mon Sep 17 00:00:00 2001 From: Benedikt Heine Date: Sat, 13 Jan 2018 23:52:40 +0100 Subject: [PATCH] Don't overwrite settings in children string_append frees the first argument. While it's a setting, settings.browser will contain a false dangling pointer. --- src/menu.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/menu.c b/src/menu.c index 3c4b890..0af694c 100644 --- a/src/menu.c +++ b/src/menu.c @@ -115,8 +115,7 @@ void open_browser(const char *in) if (browser_pid2) { exit(0); } else { - char *browser_cmd = - string_append(settings.browser, url, " "); + char *browser_cmd = g_strconcat(settings.browser, " ", url, NULL); char **cmd = g_strsplit(browser_cmd, " ", 0); execvp(cmd[0], cmd); // execvp won't return if it's successful