nagbalae/dunst
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't overwrite settings in children

Browse Source 
string_append frees the first argument. While it's a setting,
settings.browser will contain a false dangling pointer.
This commit is contained in:
Benedikt Heine 2018-01-13 23:52:40 +01:00
parent b209d06963
commit 87c0fd4d90
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/menu.c
View File

@ -115,8 +115,7 @@ void open_browser(const char *in)
if (browser_pid2) { if (browser_pid2) {
exit(0); exit(0);
} else { } else {
char *browser_cmd = char *browser_cmd = g_strconcat(settings.browser, " ", url, NULL);
string_append(settings.browser, url, " ");
char **cmd = g_strsplit(browser_cmd, " ", 0); char **cmd = g_strsplit(browser_cmd, " ", 0);
execvp(cmd[0], cmd); execvp(cmd[0], cmd);
// execvp won't return if it's successful // execvp won't return if it's successful