nagbalae/dunst
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't unconditionally append to dmenu_input

Browse Source 
When generating the list of urls to pass to dmenu, string_append with a
newline as a separator was called unconditionally. This caused a newline
character to be added for each notification even if it didn't contain
any urls, leading to empty items in dmenu.

Fixes #300
This commit is contained in:
Nikos Tsipinakis 2017-02-21 22:37:50 +02:00
parent f624c42432
commit 375fcad223
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/menu.c
View File

@ -200,7 +200,10 @@ void context_menu(void)
for (GList * iter = g_queue_peek_head_link(displayed); iter; for (GList * iter = g_queue_peek_head_link(displayed); iter;
iter = iter->next) { iter = iter->next) {
notification *n = iter->data; notification *n = iter->data;
if(n->urls)
dmenu_input = string_append(dmenu_input, n->urls, "\n"); dmenu_input = string_append(dmenu_input, n->urls, "\n");
if (n->actions) if (n->actions)
dmenu_input = dmenu_input =
string_append(dmenu_input, n->actions->dmenu_str, string_append(dmenu_input, n->actions->dmenu_str,