From 375fcad223321fb3d0b359f5aff5367d831504ed Mon Sep 17 00:00:00 2001 From: Nikos Tsipinakis Date: Tue, 21 Feb 2017 22:37:50 +0200 Subject: [PATCH] Don't unconditionally append to dmenu_input When generating the list of urls to pass to dmenu, string_append with a newline as a separator was called unconditionally. This caused a newline character to be added for each notification even if it didn't contain any urls, leading to empty items in dmenu. Fixes #300 --- src/menu.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/menu.c b/src/menu.c index 035d317..4681f36 100644 --- a/src/menu.c +++ b/src/menu.c @@ -200,7 +200,10 @@ void context_menu(void) for (GList * iter = g_queue_peek_head_link(displayed); iter; iter = iter->next) { notification *n = iter->data; - dmenu_input = string_append(dmenu_input, n->urls, "\n"); + + if(n->urls) + dmenu_input = string_append(dmenu_input, n->urls, "\n"); + if (n->actions) dmenu_input = string_append(dmenu_input, n->actions->dmenu_str,