13 Commits

Author SHA1 Message Date
Anton Lofgren
7a4d7fdd79 dbus: Fix iterator memory leak
The manual for g_variant_iter_next_value states the following:

"[..]
Use g_variant_unref() to drop your reference on the return value when
you no longer need it.
[..]"
https://developer.gnome.org/glib/unstable/glib-GVariant.html#g-variant-iter-next-value

For most notifications (I guess), this is not a problem, since the leak
is relatively tiny. However, for notifications that contain big chunks
of binary data, such as those sent out by the new Spotify client, it
adds up fast.

The Spotify notifications in particular contain a rather large
"icon_data" byte array (contained in a dict), which while never recorded
is never-the-less iterated over and allocated, which in turn gives rise to
issue #173.

This fixes #173.
2014-05-30 11:52:24 +02:00
Sascha Kruse
1ccb6185ac allow rule matching against category
fix issue #135
2014-03-08 15:03:38 +01:00
Giuliano Schneider
844186b77d fixed "warning: ‘g_type_init’ is deprecated" 2013-04-30 13:45:34 +02:00
Sascha Kruse
e3bce11796 dbus.c: don't unref invocation 2013-03-08 20:30:51 +01:00
Sascha Kruse
aa91688795 format introspection_data 2013-03-02 17:52:44 +01:00
Sascha Kruse
a1374ff1b0 read value hints again 2013-02-27 00:16:51 +01:00
Sascha Kruse
0368c63174 More informative error message, when dbus initialization fails 2013-02-25 22:06:57 +01:00
Sascha Kruse
43a14fa979 advertise "body-markup" capabilities 2013-02-23 03:15:23 +00:00
Sascha Kruse
4ef3cf96ff fix possible memory corruption 2013-02-23 00:46:19 +00:00
Sascha Kruse
e82da9d5e7 indent -linx --no-tabs 2013-02-21 23:23:54 +00:00
Sascha Kruse
4e92d61804 notification.{c,h} 2013-02-21 18:02:20 +00:00
Sascha Kruse
f2e42aabfd cleanup notification_* function names 2013-02-20 10:26:12 +01:00
Sascha Kruse
0dc127715f renamed dunst_dbus.* -> dbus.* 2013-02-20 08:52:54 +00:00