From 562cb9376721b19e6402f16340703c8cd16695ad Mon Sep 17 00:00:00 2001 From: Sascha kruse Date: Fri, 14 Sep 2018 13:29:13 +0200 Subject: [PATCH 1/4] remove unneeded declaration extract_urls --- src/dunst.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/dunst.h b/src/dunst.h index ac5cda6..adaa794 100644 --- a/src/dunst.h +++ b/src/dunst.h @@ -23,7 +23,6 @@ int dunst_main(int argc, char *argv[]); void usage(int exit_status); void print_version(void); -char *extract_urls(const char *str); void context_menu(void); void pause_signal_handler(int sig); From 183f29b59d53932cb12daed20ee496cce6350c1f Mon Sep 17 00:00:00 2001 From: Sascha kruse Date: Fri, 14 Sep 2018 13:30:27 +0200 Subject: [PATCH 2/4] remove dead comment --- src/dbus.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/dbus.h b/src/dbus.h index a5af524..bd5901f 100644 --- a/src/dbus.h +++ b/src/dbus.h @@ -17,7 +17,6 @@ enum reason { int initdbus(void); void dbus_tear_down(int id); -/* void dbus_poll(int timeout); */ void signal_notification_closed(notification *n, enum reason reason); void signal_action_invoked(notification *n, const char *identifier); From 199aaf1181a9dc7530f3763fdb33c700e3370fac Mon Sep 17 00:00:00 2001 From: Sascha kruse Date: Fri, 14 Sep 2018 13:36:05 +0200 Subject: [PATCH 3/4] fix comments in log.h --- src/log.h | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/log.h b/src/log.h index 9e58cca..7f643b6 100644 --- a/src/log.h +++ b/src/log.h @@ -17,14 +17,19 @@ #define DIE(...) do { LOG_C(__VA_ARGS__); exit(EXIT_FAILURE); } while (0) /** - * @return the string representation of the given `level` + * Set the current loglevel to `level` + * + * @param level The desired log level + * + * If `level` is `NULL`, nothing will be done. + * If `level` is an invalid value, nothing will be done. */ void log_set_level(GLogLevelFlags level); /** * Set the current loglevel to `level` * - * @param level The desired log level + * @param level The desired log level as a string * * If `level` is `NULL`, nothing will be done. * If `level` is an invalid value, nothing will be done. From bf286f73cd6ff8a868367e97fb1f592342c9207f Mon Sep 17 00:00:00 2001 From: Sascha kruse Date: Fri, 14 Sep 2018 14:37:27 +0200 Subject: [PATCH 4/4] remove unnecessary initialization of variable The inizialization value is never used and is overriden directly after. --- src/markup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/markup.c b/src/markup.c index 19d97ae..7affc34 100644 --- a/src/markup.c +++ b/src/markup.c @@ -136,7 +136,7 @@ void markup_strip_a(char **str, char **urls) */ void markup_strip_img(char **str, char **urls) { - const char *start = *str; + const char *start; if (urls) *urls = NULL;