nagbalae/dunst
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Properly handle error conditions from dunstctl

Browse Source
This commit is contained in:
Nikos Tsipinakis 2020-04-09 19:38:27 +02:00
parent 9049bf15b2
commit ec421f1ea1
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/dbus.c
View File

@ -583,11 +583,13 @@ GVariant *dbus_cb_dunst_Properties_Get(GDBusConnection *connection,
{
struct dunst_status status = dunst_status_get();
if (STR_EQ(property_name, "running"))
if (STR_EQ(property_name, "running")) {
return g_variant_new_boolean(status.running);
else
//TODO: is NULL as return value allowed?
} else {
LOG_W("Unknown property!\n");
*error = g_error_new(G_DBUS_ERROR, G_DBUS_ERROR_UNKNOWN_PROPERTY, "Unknown property");
return NULL;
}
}
gboolean dbus_cb_dunst_Properties_Set(GDBusConnection *connection,
@ -604,11 +606,9 @@ gboolean dbus_cb_dunst_Properties_Set(GDBusConnection *connection,
wake_up();
return true;
}
//FIXME: don't we have to return true on successful setting, but return false, if e.g. the parameter name is wrong?
//return true;
// so like this?
*error = g_error_new(G_DBUS_ERROR, G_DBUS_ERROR_UNKNOWN_PROPERTY, "Unknown property");
return false;
}