From 84e5a0bf2698a235a0ef00f67324756d6b136163 Mon Sep 17 00:00:00 2001 From: Benedikt Heine Date: Thu, 3 Jan 2019 12:10:39 +0100 Subject: [PATCH] Make notification_is_duplicate test icons Before, it only did test for `ASSERT_FALSE` both times. So a raw_image wasn't guaranteed to be a condition to falsify the return. Using the single field function, will test for both cases. --- test/notification.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/test/notification.c b/test/notification.c index ad9b8e3..7d4704a 100644 --- a/test/notification.c +++ b/test/notification.c @@ -30,11 +30,8 @@ TEST test_notification_is_duplicate(struct notification *a, ASSERT(notification_is_duplicate(a, b)); - char *tmp = b->icon; enum icon_position icon_setting_tmp = settings.icon_position; - b->icon = "Test1"; - settings.icon_position = ICON_OFF; ASSERT(notification_is_duplicate(a, b)); //Setting pointer to a random value since we are checking for null @@ -43,18 +40,17 @@ TEST test_notification_is_duplicate(struct notification *a, b->raw_icon = NULL; settings.icon_position = ICON_LEFT; - ASSERT_FALSE(notification_is_duplicate(a, b)); + CHECK_CALL(test_notification_is_duplicate_field(&(b->icon), a, b)); b->raw_icon = (struct raw_image*)0xff; ASSERT_FALSE(notification_is_duplicate(a, b)); b->raw_icon = NULL; settings.icon_position = ICON_RIGHT; - ASSERT_FALSE(notification_is_duplicate(a, b)); + CHECK_CALL(test_notification_is_duplicate_field(&(b->icon), a, b)); b->raw_icon = (struct raw_image*)0xff; ASSERT_FALSE(notification_is_duplicate(a, b)); b->raw_icon = NULL; - b->icon = tmp; settings.icon_position = icon_setting_tmp; ASSERT(notification_is_duplicate(a, b));