nagbalae/dunst
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Microoptimisation in get_sleep_time

Browse Source 
Setting the value to INT_MAX instead of 0 allows to remove the boolean
check if value even has been set.
This commit is contained in:
Benedikt Heine 2017-08-29 01:11:53 +02:00
parent 4c09b4370a
commit 7a02d8e48a
1 changed files with 3 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/dunst.c
View File

@ -181,8 +181,7 @@ static int get_sleep_time(void)
return 1; return 1;
} }
bool have_ttl = false; int min_ttl = INT_MAX;
int min_ttl = 0;
int max_age = 0; int max_age = 0;
for (GList *iter = g_queue_peek_head_link(displayed); iter; for (GList *iter = g_queue_peek_head_link(displayed); iter;
iter = iter->next) { iter = iter->next) {
@ -191,12 +190,7 @@ static int get_sleep_time(void)
max_age = MAX(max_age, notification_get_age(n)); max_age = MAX(max_age, notification_get_age(n));
int ttl = notification_get_ttl(n); int ttl = notification_get_ttl(n);
if (ttl >= 0) { if (ttl >= 0) {
if (have_ttl) { min_ttl = MIN(min_ttl, ttl);
min_ttl = MIN(min_ttl, ttl);
} else {
min_ttl = ttl;
have_ttl = true;
}
} }
} }
@ -207,11 +201,7 @@ static int get_sleep_time(void)
return 1; return 1;
} }
if (!have_ttl) { min_timeout = MIN(show_age_timeout, min_ttl);
min_timeout = show_age_timeout;
} else {
min_timeout = MIN(show_age_timeout, min_ttl);
}
/* show_age_timeout might be negative */ /* show_age_timeout might be negative */
if (min_timeout < 1) { if (min_timeout < 1) {