From 08019dc2686cb99ae740b9b8f0f8368fcb2ed665 Mon Sep 17 00:00:00 2001
From: Benedikt Heine <bebe@bebehei.de>
Date: Wed, 31 Oct 2018 13:41:41 +0100
Subject: [PATCH 1/4] Move context_menu into right header

---
 src/dunst.c | 2 --
 src/dunst.h | 2 --
 src/menu.c  | 5 +----
 src/menu.h  | 5 +++++
 src/rules.c | 2 ++
 src/x11/x.c | 1 +
 6 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/src/dunst.c b/src/dunst.c
index 7ffcfcb..7b6b4b9 100644
--- a/src/dunst.c
+++ b/src/dunst.c
@@ -30,8 +30,6 @@
 
 GMainLoop *mainloop = NULL;
 
-GSList *rules = NULL;
-
 /* misc functions */
 static gboolean run(void *data);
 
diff --git a/src/dunst.h b/src/dunst.h
index adaa794..bd456c4 100644
--- a/src/dunst.h
+++ b/src/dunst.h
@@ -14,7 +14,6 @@
 #define ColFG 1
 #define ColBG 0
 
-extern GSList *rules;
 extern const char *colors[3][3];
 
 void wake_up(void);
@@ -23,7 +22,6 @@ int dunst_main(int argc, char *argv[]);
 
 void usage(int exit_status);
 void print_version(void);
-void context_menu(void);
 void pause_signal_handler(int sig);
 
 #endif
diff --git a/src/menu.c b/src/menu.c
index fe324ae..e427f29 100644
--- a/src/menu.c
+++ b/src/menu.c
@@ -270,10 +270,7 @@ char *invoke_dmenu(const char *dmenu_input)
         return ret;
 }
 
-/*
- * Open the context menu that let's the user
- * select urls/actions/etc
- */
+/* see menu.h */
 void context_menu(void)
 {
         GError *err = NULL;
diff --git a/src/menu.h b/src/menu.h
index 298fd85..b93f78b 100644
--- a/src/menu.h
+++ b/src/menu.h
@@ -7,5 +7,10 @@ void open_browser(const char *in);
 void invoke_action(const char *action);
 void regex_teardown(void);
 
+/**
+ * Open the context menu that lets the user select urls/actions/etc.
+ */
+void context_menu(void);
+
 #endif
 /* vim: set tabstop=8 shiftwidth=8 expandtab textwidth=0: */
diff --git a/src/rules.c b/src/rules.c
index a6d373c..4f13977 100644
--- a/src/rules.c
+++ b/src/rules.c
@@ -7,6 +7,8 @@
 
 #include "dunst.h"
 
+GSList *rules = NULL;
+
 /*
  * Apply rule to notification.
  */
diff --git a/src/x11/x.c b/src/x11/x.c
index b96174a..673cd1a 100644
--- a/src/x11/x.c
+++ b/src/x11/x.c
@@ -24,6 +24,7 @@
 #include "src/dunst.h"
 #include "src/log.h"
 #include "src/markup.h"
+#include "src/menu.h"
 #include "src/notification.h"
 #include "src/queues.h"
 #include "src/settings.h"

From a24a464fbc8d52d52f595712092435622da8dda5 Mon Sep 17 00:00:00 2001
From: Benedikt Heine <bebe@bebehei.de>
Date: Wed, 31 Oct 2018 13:42:12 +0100
Subject: [PATCH 2/4] Remove superfluous pause_signal_handler func

---
 src/dunst.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/dunst.h b/src/dunst.h
index bd456c4..a0d0519 100644
--- a/src/dunst.h
+++ b/src/dunst.h
@@ -22,7 +22,6 @@ int dunst_main(int argc, char *argv[]);
 
 void usage(int exit_status);
 void print_version(void);
-void pause_signal_handler(int sig);
 
 #endif
 /* vim: set tabstop=8 shiftwidth=8 expandtab textwidth=0: */

From 9cd600f0bf6d2bf74d1fb08a1de5bcf503d23010 Mon Sep 17 00:00:00 2001
From: Benedikt Heine <bebe@bebehei.de>
Date: Wed, 31 Oct 2018 13:54:08 +0100
Subject: [PATCH 3/4] Remove unused function get_filename_ext

This function had been copied 100% out of the stackoverflow answer
https://stackoverflow.com/a/24976006
---
 src/icon.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/src/icon.c b/src/icon.c
index ab43e19..1e9512c 100644
--- a/src/icon.c
+++ b/src/icon.c
@@ -15,13 +15,6 @@ static bool is_readable_file(const char *filename)
         return (access(filename, R_OK) != -1);
 }
 
-const char *get_filename_ext(const char *filename)
-{
-        const char *dot = strrchr(filename, '.');
-        if (!dot || dot == filename) return "";
-        return dot + 1;
-}
-
 static cairo_status_t read_from_buf(void *closure, unsigned char *data, unsigned int size)
 {
         GByteArray *buf = (GByteArray *)closure;

From 851f8a733965f69444a0a0cfe61db34a881e56a3 Mon Sep 17 00:00:00 2001
From: Benedikt Heine <bebe@bebehei.de>
Date: Wed, 31 Oct 2018 14:24:03 +0100
Subject: [PATCH 4/4] Rename dbus methods consistently

---
 src/dbus.c  | 4 ++--
 src/dbus.h  | 4 ++--
 src/dunst.c | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/dbus.c b/src/dbus.c
index 7785853..1e4710d 100644
--- a/src/dbus.c
+++ b/src/dbus.c
@@ -569,7 +569,7 @@ static struct raw_image *get_raw_image_from_data_hint(GVariant *icon_data)
         return image;
 }
 
-int initdbus(void)
+int dbus_init(void)
 {
         guint owner_id;
 
@@ -592,7 +592,7 @@ int initdbus(void)
         return owner_id;
 }
 
-void dbus_tear_down(int owner_id)
+void dbus_teardown(int owner_id)
 {
         g_clear_pointer(&introspection_data, g_dbus_node_info_unref);
 
diff --git a/src/dbus.h b/src/dbus.h
index 217c74c..4a72479 100644
--- a/src/dbus.h
+++ b/src/dbus.h
@@ -15,8 +15,8 @@ enum reason {
         REASON_MAX = 4,   /**< Maximum value, useful for boundary checking */
 };
 
-int initdbus(void);
-void dbus_tear_down(int id);
+int dbus_init(void);
+void dbus_teardown(int id);
 void signal_notification_closed(struct notification *n, enum reason reason);
 void signal_action_invoked(const struct notification *n, const char *identifier);
 
diff --git a/src/dunst.c b/src/dunst.c
index 7b6b4b9..0be3d8f 100644
--- a/src/dunst.c
+++ b/src/dunst.c
@@ -141,7 +141,7 @@ int dunst_main(int argc, char *argv[])
                 usage(EXIT_SUCCESS);
         }
 
-        int owner_id = initdbus();
+        int dbus_owner_id = dbus_init();
 
         mainloop = g_main_loop_new(NULL, FALSE);
 
@@ -180,7 +180,7 @@ int dunst_main(int argc, char *argv[])
         g_source_remove(term_src);
         g_source_remove(int_src);
 
-        dbus_tear_down(owner_id);
+        dbus_teardown(dbus_owner_id);
 
         teardown();