From 52b08e4f19e6e2cf4b334f021505cba2244953ae Mon Sep 17 00:00:00 2001 From: Hugo Osvaldo Barrera Date: Wed, 10 May 2017 12:50:11 -0300 Subject: [PATCH] Don't hardcode a DISPLAY variable Hardcoding a DISPLAY variable is a bad idea because it means that dunst will only run on X11, and only for that specific configuration. FWIW, this actually applies to any desktop app run via systemd: 1. `DISPLAY` should be set by `systemctl --user set-environment` elsewhere. 2. `DISPLAY=:0` is not universally valid. 3. This breaks dunst if attempting to run wayland, and requires manually starting it (eg: not via systemd), or editing the file. --- contrib/dunst.systemd.service.in | 1 - 1 file changed, 1 deletion(-) diff --git a/contrib/dunst.systemd.service.in b/contrib/dunst.systemd.service.in index 61ca237..54aec39 100644 --- a/contrib/dunst.systemd.service.in +++ b/contrib/dunst.systemd.service.in @@ -6,7 +6,6 @@ Documentation=man:dunst(1) Type=dbus BusName=org.freedesktop.Notifications ExecStart=##PREFIX##/bin/dunst -Environment=DISPLAY=:0 [Install] WantedBy=default.target