Harden against undefined X Atoms

Fixes #589
2019-01-15 18:29:32 +01:00 · 2019-01-15 18:29:32 +01:00 · 19c9a8e296
commit 19c9a8e296
parent fb29047679
1 changed files with 12 additions and 8 deletions
--- a/src/x11/screen.c
+++ b/src/x11/screen.c
@ -256,15 +256,19 @@ bool window_is_fullscreen(Window window)

        if (result == Success) {
                for(int i = 0; i < n_items; i++) {
-                        char *atom = XGetAtomName(xctx.dpy, ((Atom*)prop_to_return)[i]);
+                        Atom atom = ((Atom*) prop_to_return)[i];
+                        if (!atom)
+                                continue;

-                        if (atom) {
-                                if(STR_EQ("_NET_WM_STATE_FULLSCREEN", atom))
-                                        fs = true;
-                                XFree(atom);
-                                if(fs)
-                                        break;
-                        }
+                        char *s = XGetAtomName(xctx.dpy, atom);
+                        if (!s)
+                                continue;
+
+                        if (STR_EQ(s, "_NET_WM_STATE_FULLSCREEN"))
+                                fs = true;
+                        XFree(s);
+                        if (fs)
+                                break;
                }
        }