From 187d3f9ab9fb63c212c8960b92f53a03964bfd90 Mon Sep 17 00:00:00 2001 From: Nikos Tsipinakis Date: Thu, 15 Dec 2016 19:13:08 +0200 Subject: [PATCH] Invalid boolean values should fall back to the default Previously, an invalid value was always false --- src/option_parser.c | 2 +- test/option_parser.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/option_parser.c b/src/option_parser.c index 3617a89..7b682cd 100644 --- a/src/option_parser.c +++ b/src/option_parser.c @@ -175,7 +175,7 @@ int ini_get_bool(char *section, char *key, int def) case '0': return false; default: - return false; + return def; } } } diff --git a/test/option_parser.c b/test/option_parser.c index 3a44b7a..b45788f 100644 --- a/test/option_parser.c +++ b/test/option_parser.c @@ -33,6 +33,7 @@ TEST test_ini_get_bool(void) ASSERT(ini_get_bool(bool_section, "boolbin1", false)); ASSERT_FALSE(ini_get_bool(bool_section, "boolbin0", true)); + ASSERT(ini_get_bool(bool_section, "boolinvalid", true)); ASSERT_FALSE(ini_get_bool(bool_section, "boolinvalid", false)); ASSERT(ini_get_bool(bool_section, "nonexistent", true));