nagbalae/dunst
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix crash when triggering actions via dunstctl

Browse Source 
g_list_nth_data was used to query the notification list, but in the code
it was erroneously assumed that a GList object was returned rather than
a notification.

One of the many pitfalls of generic pointers...

Fixes #727
This commit is contained in:
Nikos Tsipinakis 2020-07-02 19:44:26 +02:00
parent 8afb7fcd1a
commit 0de8610b67
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/dbus.c
View File

@ -224,10 +224,9 @@ static void dbus_cb_dunst_NotificationAction(GDBusConnection *connection,
return; return;
} }
const GList *list = g_list_nth_data(queues_get_displayed(), notification_nr); struct notification *n = g_list_nth_data(queues_get_displayed(), notification_nr);
if (list && list->data) { if (n) {
struct notification *n = list->data;
LOG_D("CMD: Calling action for notification %s", n->summary); LOG_D("CMD: Calling action for notification %s", n->summary);
notification_do_action(n); notification_do_action(n);
} }